[Open-FCoE] [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project

Christoph Hellwig hch at infradead.org
Wed Nov 28 07:44:26 UTC 2007


I just did a very quick glance over the tree.  Some extremly highlevel
comments to start with before actually starting the source review:


 - why do you need your own libcrc?  lib/crc32.c has a crc32_le
 - libsa should go.  Much of it is just wrappers of kernel functions
   that should be used directly.  Other like that hash, even or state
   helpers might either be opencoded in the caller or made completely
   generic in lib/.  Probably the former but we'll have to see.



More information about the devel mailing list