[Open-FCoE] [RFC PATCH 00/15] rport state machine and locking

Robert Love robert.w.love at intel.com
Tue Sep 2 22:36:52 UTC 2008


The following series implements a change to the rport state machine and
applies a locking strategy to that state machine.

1) A callback function is added to the LP for RP events (READY, FAILED, LOGO)
2) GNN_ID and GPN_ID are moved into the RP state machine
3) The RP state machine starts in a work thread
4) A READY state is added to the RP state machine
5) The RP state machine locking has been given a locking strategy
6) RP only has one error/retry handling routine
7) Naming conventions are changed
    rp (remote port) = fc_rport pointer
    rpp (remote port private) = fc_rport_libfc_priv pointer

I think these patches still need a little cleaning up, but they're mostly good.
I'm curious what everyone thinks about the folowing changes to:

a) the locking policy
b) the event callback mechanism
c) the use of work threads
d) the consolidation of fc_rport_error and fc_rport_retry.

All comments are welcome. If there are no major issues I'll do a little cleanup,
drop the RFC, resubmit and then commit.
-- 
//Rob



More information about the devel mailing list