[Open-FCoE] [RFC PATCH 02/15] libfc: rm NS special case in a few places fc_rport.c

Robert Love robert.w.love at intel.com
Tue Sep 2 22:37:02 UTC 2008


There are a few instances where the rport is checking
if the rport transitioning through the RP state
machine is the NS rport. If it is an event is the RP
will determine what the LP should do next.

This patch removes unnecessary calls from the RP to
the LP when the rport is for the name server.

Signed-off-by: Robert Love <robert.w.love at intel.com>
---

 drivers/scsi/libfc/fc_rport.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index 0d6be63..6bac44f 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
@@ -374,13 +374,6 @@ static void fc_rport_reject(struct fc_rport *rport)
 		fc_rport_state_enter(rport, RPORT_ST_READY);
 		if (fc_rp_debug)
 			FC_DBG("remote %6x ready", rport->port_id);
-		if (rport == lp->dns_rp &&
-		    lp->state == LPORT_ST_DNS) {
-			fc_lport_lock(lp);
-			del_timer(&lp->state_timer);
-			lp->tt.dns_register(lp);
-			fc_lport_unlock(lp);
-		}
 		break;
 	case RPORT_ST_LOGO:
 		fc_rport_state_enter(rport, RPORT_ST_INIT);
@@ -760,7 +753,6 @@ static void fc_rport_rtv_resp(struct fc_seq *sp, struct fc_frame *fp,
 {
 	struct fc_rport *rport = rp_arg;
 	struct fc_rport_libfc_priv *rp = rport->dd_data;
-	struct fc_lport *lp = rp->local_port;
 	u8 op;
 
 	if (IS_ERR(fp)) {
@@ -794,13 +786,6 @@ static void fc_rport_rtv_resp(struct fc_seq *sp, struct fc_frame *fp,
 	fc_rport_unlock(rport);
 	if (fc_rp_debug)
 		FC_DBG("remote %6x ready", rport->port_id);
-	if (rport == lp->dns_rp &&
-	    lp->state == LPORT_ST_DNS) {
-		fc_lport_lock(lp);
-		del_timer(&lp->state_timer);
-		lp->tt.dns_register(lp);
-		fc_lport_unlock(lp);
-	}
 	fc_frame_free(fp);
 }
 




More information about the devel mailing list