[Open-FCoE] [PATCH] libfc: fix fc_lport_error bug in flogi_recv

Robert Love robert.w.love at intel.com
Mon Sep 8 16:21:29 UTC 2008


The 'out' goto was intended for error cases, but was
getting called always.

Signed-off-by: Robert Love <robert.w.love at intel.com>
---

 drivers/scsi/libfc/fc_lport.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c
index b06f519..aaeab59 100644
--- a/drivers/scsi/libfc/fc_lport.c
+++ b/drivers/scsi/libfc/fc_lport.c
@@ -785,8 +785,10 @@ fc_lport_flogi_resp(struct fc_seq *sp, struct fc_frame *fp, void *lp_arg)
 	unsigned int e_d_tov;
 	u16 mfs;
 
-	if (IS_ERR(fp))
-		goto out;
+	if (IS_ERR(fp)) {
+		fc_lport_error(lp, fp);
+		return;
+	}
 
 	fh = fc_frame_header_get(fp);
 	did = ntoh24(fh->fh_d_id);
@@ -835,8 +837,6 @@ fc_lport_flogi_resp(struct fc_seq *sp, struct fc_frame *fp, void *lp_arg)
 		FC_DBG("bad FLOGI response\n");
 	}
 	fc_frame_free(fp);
-out:
-	fc_lport_error(lp, fp);
 }
 
 /*




More information about the devel mailing list