[Open-FCoE] [RFC PATCH 09/28] libfc: Clean up fc_rport_reject

Joe Eykholt jre at nuovasystems.com
Fri Sep 12 16:00:56 UTC 2008


Robert Love wrote:
> 1. only call fc_rport_reject from fc_rport_error
> 
> 2. Don't have fc_rport_reject check the LP state
...

>  static void fc_rport_timeout(struct work_struct *work)
>  {
> @@ -540,9 +525,7 @@ static void fc_rport_plogi_resp(struct fc_seq *sp, struct fc_frame *fp,
>  			rjp = fc_frame_payload_get(fp, sizeof(*rjp));
>  			if (op == ELS_LS_RJT && rjp != NULL &&
>  			    rjp->er_reason == ELS_RJT_INPROG)
> -				fc_rport_error(rport, fp);    /* try again */
> -			else
> -				fc_rport_reject(rport);   /* error */
> +				fc_rport_error(rport, fp);
>  		}
>  		fc_rport_unlock(rport);
>  		fc_frame_free(fp);

This would change semantics so that it doesn't call _error() in
the deleted else case.  Since we now want to call _error() in both
cases, the if-statement isn't needed anymore. That means rjp isn't
used, so more code to delete!  Yay!

      Regards,
      Joe




More information about the devel mailing list