[Open-FCoE] [PATCH 1/1] fc class: add rogue rport support

James Smart James.Smart at Emulex.Com
Fri Sep 12 19:48:40 UTC 2008



Mike Christie wrote:
> James Smart wrote
>>>  struct fc_rport *
>>>  fc_remote_port_add(struct Scsi_Host *shost, int channel,
>>> -       struct fc_rport_identifiers  *ids)
>>> +                  struct fc_rport *rogue_rport,
>>> +                  struct fc_rport_identifiers  *ids)
>> ... rest of fc_remote_port_add changes.
>>
>> I like how much code you cleaned up by replacing the per-list search
>> paths, but it's thrown me. Proceed with what's there, and I'll post a
> 
> I did not know what, "It's thrown me" meant? Did you mean you do not
> have enough time to fully review it? And then does proceed with what's
> there mean mean use the original code?

just I've run out of time for today to look at it. Proceed means - go 
with your patch, but I would like my prior comments addressed if you 
agree with them.

-- james s



More information about the devel mailing list