[Open-FCoE] [PATCH 1/1] fc class: add rogue rport support

Mike Christie michaelc at cs.wisc.edu
Fri Sep 12 20:02:44 UTC 2008


James Smart wrote:
> 
> 
> Mike Christie wrote:
>> James Smart wrote
>>>>  struct fc_rport *
>>>>  fc_remote_port_add(struct Scsi_Host *shost, int channel,
>>>> -       struct fc_rport_identifiers  *ids)
>>>> +                  struct fc_rport *rogue_rport,
>>>> +                  struct fc_rport_identifiers  *ids)
>>> ... rest of fc_remote_port_add changes.
>>>
>>> I like how much code you cleaned up by replacing the per-list search
>>> paths, but it's thrown me. Proceed with what's there, and I'll post a
>>
>> I did not know what, "It's thrown me" meant? Did you mean you do not
>> have enough time to fully review it? And then does proceed with what's
>> there mean mean use the original code?
> 
> just I've run out of time for today to look at it. Proceed means - go 

Ok. Don't feel rushed. Sorry about that. Thanks for the review. I will 
not send it to linux-scsi for review for some time to make sure you have 
time to review it and try it out.

> with your patch, but I would like my prior comments addressed if you 
> agree with them.
> 

Yeah, I agree and am fixing them.



More information about the devel mailing list