[Open-FCoE] [PATCH] fcoe: use ETH_P_FIP for skb->protocol of FIPframes

Joe Eykholt jeykholt at cisco.com
Fri Apr 3 22:48:37 UTC 2009



>-----Original Message-----
>From: devel-bounces at open-fcoe.org
>[mailto:devel-bounces at open-fcoe.org] On Behalf Of Chris Leech
>Sent: Friday, April 03, 2009 3:21 PM
>To: devel at open-fcoe.org
>Subject: [Open-FCoE] [PATCH] fcoe: use ETH_P_FIP for
>skb->protocol of FIPframes
>
>FIP frames should leave the fcoe layer with skb->protocol set
>to ETH_P_FIP, not ETH_P_802_3.

I think the reason 802_3 was set was to accommodate the tc command, to get
the right 803.1p tags.  Maybe that's been solved some other way by now.


How is skb->protocol used on output?

        Thanks,
        Joe
 
>Signed-off-by: Chris Leech <christopher.leech at intel.com>
>---
>
> drivers/scsi/fcoe/libfcoe.c |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/fcoe/libfcoe.c
>b/drivers/scsi/fcoe/libfcoe.c index f410f4a..b527274 100644
>--- a/drivers/scsi/fcoe/libfcoe.c
>+++ b/drivers/scsi/fcoe/libfcoe.c
>@@ -213,7 +213,7 @@ static void fcoe_ctlr_solicit(struct
>fcoe_ctlr *fip, struct fcoe_fcf *fcf)
>       sol->desc.size.fd_size = htons(fcoe_size);
>
>       skb_put(skb, sizeof(*sol));
>-      skb->protocol = htons(ETH_P_802_3);
>+      skb->protocol = htons(ETH_P_FIP);
>       skb_reset_mac_header(skb);
>       skb_reset_network_header(skb);
>       fip->send(fip, skb);
>@@ -365,7 +365,7 @@ static void
>fcoe_ctlr_send_keep_alive(struct fcoe_ctlr *fip, int ports, u8 *sa)
>       }
>
>       skb_put(skb, len);
>-      skb->protocol = htons(ETH_P_802_3);
>+      skb->protocol = htons(ETH_P_FIP);
>       skb_reset_mac_header(skb);
>       skb_reset_network_header(skb);
>       fip->send(fip, skb);
>@@ -424,7 +424,7 @@ static int fcoe_ctlr_encaps(struct fcoe_ctlr *fip,
>       if (dtype != ELS_FLOGI)
>               memcpy(mac->fd_mac, fip->data_src_addr, ETH_ALEN);
>
>-      skb->protocol = htons(ETH_P_802_3);
>+      skb->protocol = htons(ETH_P_FIP);
>       skb_reset_mac_header(skb);
>       skb_reset_network_header(skb);
>       return 0;
>
>_______________________________________________
>devel mailing list
>devel at open-fcoe.org
>http://www.open-fcoe.org/mailman/listinfo/devel
>




More information about the devel mailing list