[Open-FCoE] [RFC PATCH] fcoe-utils: remove driver namd and version from fcoeadm display

Love, Robert W robert.w.love at intel.com
Wed Apr 15 20:22:22 UTC 2009


Steve Ma wrote:
> The Driver Name and Driver Version are optional HBA attributes
> according to t11 FC-HBA spec. Since it is for information only,
> it is removed to simplify the display.

Why remove this info? It may not be a requirement, but I think the
display is pretty clean already and this info is nice-to-have.

> ---
> 
>  fcoeadm_display.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fcoeadm_display.c b/fcoeadm_display.c
> index bdddb43..39293cb 100644
> --- a/fcoeadm_display.c
> +++ b/fcoeadm_display.c
> @@ -209,8 +209,6 @@ show_hba_info(int hba_index,
>  	HBA_ADAPTERATTRIBUTES *hba_info, int flags) printf("    Revision:  
>  	%s\n", hba_info->HardwareVersion); printf("    Manufacturer:    
>  	%s\n", hba_info->Manufacturer); printf("    Serial Number:   
> %s\n", hba_info->SerialNumber); 
> -	printf("    Driver:           %s %s\n", hba_info->DriverName,
> -						hba_info->DriverVersion);
>  	printf("    Number of Ports:  %d\n", hba_info->NumberOfPorts);
>  }
> 
> 
> _______________________________________________
> devel mailing list
> devel at open-fcoe.org
> http://www.open-fcoe.org/mailman/listinfo/devel




More information about the devel mailing list