[Open-FCoE] [RFC PATCH] fcoe-utils: remove driver namd and version from fcoeadm display

Joe Eykholt jeykholt at cisco.com
Wed Apr 15 22:26:33 UTC 2009


Ma, Steve wrote:
> 
>> -----Original Message-----
>> From: Love, Robert W
>> Sent: Wednesday, April 15, 2009 1:22 PM
>> To: Ma, Steve; devel at open-fcoe.org
>> Subject: RE: [Open-FCoE] [RFC PATCH] fcoe-utils: remove driver namd and
>> version from fcoeadm display
>>
>> Steve Ma wrote:
>>> The Driver Name and Driver Version are optional HBA attributes
>>> according to t11 FC-HBA spec. Since it is for information only,
>>> it is removed to simplify the display.
>> Why remove this info? It may not be a requirement, but I think the
>> display is pretty clean already and this info is nice-to-have.
>>
> Currently this info is junk characters. The existing code used to find the driver name of the NIC card. Now it is broken. If this info is needed, we can try to fix it instead of removing it temporarily.

The library should provide some testable value when there's no information.
Perhaps all zeros (whatever the hba-api spec says).
Then fcoeadm could just show empty strings (or "unknown") when that value is returned.

	Joe

>>> ---
>>>
>>>  fcoeadm_display.c |    2 --
>>>
>>> diff --git a/fcoeadm_display.c b/fcoeadm_display.c
>>> index bdddb43..39293cb 100644
>>> --- a/fcoeadm_display.c
>>> +++ b/fcoeadm_display.c
>>> @@ -209,8 +209,6 @@ show_hba_info(int hba_index,
>>>  	HBA_ADAPTERATTRIBUTES *hba_info, int flags) printf("    Revision:
>>>  	%s\n", hba_info->HardwareVersion); printf("    Manufacturer:
>>>  	%s\n", hba_info->Manufacturer); printf("    Serial Number:
>>> %s\n", hba_info->SerialNumber);
>>> -	printf("    Driver:           %s %s\n", hba_info->DriverName,
>>> -						hba_info->DriverVersion);
>>>  	printf("    Number of Ports:  %d\n", hba_info->NumberOfPorts);
>>>  }
>>>
>>>
>>> _______________________________________________
>>> devel mailing list
>>> devel at open-fcoe.org
>>> http://www.open-fcoe.org/mailman/listinfo/devel
> 
> _______________________________________________
> devel mailing list
> devel at open-fcoe.org
> http://www.open-fcoe.org/mailman/listinfo/devel




More information about the devel mailing list