[Open-FCoE] [PATCH 2/2] fcoe: Add runtime debugging enabling

Deepak Tawri deepak at netxen.com
Fri Feb 6 06:46:59 UTC 2009


Or how about modifying FCOE_DBG itself
to add "\n" sothat every caller doesn't
need to do that. Also, programmers won't
need to remember to add "\n" every time
they call this macro.

thanks,
deepak

Zou, Yi wrote:
>> @@ -191,22 +194,19 @@ int fcoe_rcv(struct sk_buff *skb, struct
>> net_device *dev,
>> 	fc = container_of(ptype, struct fcoe_softc, fcoe_packet_type);
>> 	lp = fc->lp;
>> 	if (unlikely(lp == NULL)) {
>> -		FC_DBG("cannot find hba structure");
>> +		FCOE_DBG("cannot find hba structure");
>> 		goto err2;
>> 	}
>>
>> -	if (unlikely(debug_fcoe)) {
>> -		FC_DBG("skb_info: len:%d data_len:%d head:%p data:%p
>> tail:%p "
>> -		       "end:%p sum:%d dev:%s", skb->len, skb->data_len,
>> -		       skb->head, skb->data, skb_tail_pointer(skb),
>> -		       skb_end_pointer(skb), skb->csum,
>> -		       skb->dev ? skb->dev->name : "<NULL>");
>> -
>> -	}
>> +	FCOE_DBG("skb_info: len:%d data_len:%d head:%p data:%p tail:%p "
>> +		 "end:%p sum:%d dev:%s", skb->len, skb->data_len,
>> +		 skb->head, skb->data, skb_tail_pointer(skb),
>> +		 skb_end_pointer(skb), skb->csum,
>> +		 skb->dev ? skb->dev->name : "<NULL>");
> 
> Just a minor note, it will be great if you also add "\n" to the end in
> this one and several others. 
> 
> Thanks,
> 
> yi
> 
> _______________________________________________
> devel mailing list
> devel at open-fcoe.org
> http://www.open-fcoe.org/mailman/listinfo/devel
> 




More information about the devel mailing list