[Open-FCoE] [PATCH] libfc: rport retry on LS_RJT from certain ELS

Chris Leech christopher.leech at intel.com
Thu Jan 15 23:46:40 UTC 2009


> The patch looks good.  It might be better to have two error routines, one
> which retries and one which doesn't.  The one that retries can then call
> the one that doesn't, in the case that retries are exhausted.  That generates
> a little less code, since the callers now don't have to pass a parameter.
> It isn't performance critical.

I like that idea, I'll see what the patch would look like with those
changes.

> But, your way is fine, too.
> 
> The error FC_EX_CLOSED, which is caused by the fc_exch_mgr_reset() when a link
> goes down (and should be when a remote port is deleted), should not cause a retry,
> though (it didn't before).  That's the only other error besides FC_EX_TIMEOUT
> for now.

OK, I'll check to make sure I handle the closed condition.

Thanks for the review Joe.

- Chris



More information about the devel mailing list