[Open-FCoE] [PATCH 3/9] libfc: fix RPORT_TO_PRIV and PRIV_TO_RPORT() macros.

Joe Eykholt jeykholt at cisco.com
Wed Jul 8 00:12:32 UTC 2009


These macros introduce extra undesirable semicolons that keep
them from being used in expressions, and they don't protect
against being passed an expression.

Add parens and remove the semicolons.

Signed-off-by: Joe Eykholt <jeykholt at cisco.com>
---
 include/scsi/libfc.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/include/scsi/libfc.h b/include/scsi/libfc.h
index d8fe896..f2d5ddf 100644
--- a/include/scsi/libfc.h
+++ b/include/scsi/libfc.h
@@ -224,9 +224,9 @@ struct fc_rport_libfc_priv {
 };
 
 #define PRIV_TO_RPORT(x)						\
-	(struct fc_rport *)((void *)x - sizeof(struct fc_rport));
+	((struct fc_rport *)((void *)(x) - sizeof(struct fc_rport)))
 #define RPORT_TO_PRIV(x)						\
-	(struct fc_rport_libfc_priv *)((void *)x + sizeof(struct fc_rport));
+	((struct fc_rport_libfc_priv *)((void *)(x) + sizeof(struct fc_rport)))
 
 static inline void fc_rport_set_name(struct fc_rport *rport, u64 wwpn, u64 wwnn)
 {





More information about the devel mailing list