[Open-FCoE] [PATCH V2 11/13] fcoe: add mutex to protect create and destroy

Robert Love robert.w.love at intel.com
Wed Jul 8 21:13:29 UTC 2009


On Wed, 2009-07-08 at 10:40 -0700, Chris Leech wrote:
> Rather than rely on the hostlist_lock to be held while creating exchange
> managers, serialize fcoe instance creation and destruction with a mutex.
> This will allow the hostlist addition to be moved out of fcoe_if_create(),
> which will simplify NPIV support.
> 
Is there a reason that we don't use the rtnl_lock for protection? It's
already held when we get the NETDEV_UNREGISTER event (added in patch
13/13). I believe that doing so would remove the need to defer the
fcoe_destroy() call since the deferral is only needed so that we don't
grab the rtnl_lock twice.





More information about the devel mailing list