[Open-FCoE] [RFC PATCH 07/14] fcoe-utils: Remove function name from print statements

Robert Love robert.w.love at intel.com
Wed Jul 8 22:18:05 UTC 2009


Printing the function names is not appropriate for general
logging statements. They're not needed for debugging statements
either; grepping the small code base can easly show a developer
where the call came from.

Signed-off-by: Robert Love <robert.w.love at intel.com>
---

 fcoemon.h       |    2 +-
 fcoemon_utils.c |   13 -------------
 fcoemon_utils.h |    1 -
 3 files changed, 1 insertions(+), 15 deletions(-)

diff --git a/fcoemon.h b/fcoemon.h
index 4c0b6ea..4cd39c0 100644
--- a/fcoemon.h
+++ b/fcoemon.h
@@ -27,7 +27,7 @@ int fcm_debug;
  */
 #define FCM_LOG(...)							\
 	do {								\
-		sa_log_func(__func__, __VA_ARGS__);			\
+		sa_log(__VA_ARGS__);					\
 	} while (0)
 
 #define FCM_LOG_ERR(error, ...) \
diff --git a/fcoemon_utils.c b/fcoemon_utils.c
index bebe014..0bb013e 100644
--- a/fcoemon_utils.c
+++ b/fcoemon_utils.c
@@ -78,19 +78,6 @@ sa_log(const char *format, ...)
 }
 
 /*
- * log with function name.
- */
-void
-sa_log_func(const char *func, const char *format, ...)
-{
-	va_list arg;
-
-	va_start(arg, format);
-	sa_log_va(func, format, arg);
-	va_end(arg);
-}
-
-/*
  * log with error number.
  */
 void
diff --git a/fcoemon_utils.h b/fcoemon_utils.h
index 12769f6..05faac2 100644
--- a/fcoemon_utils.h
+++ b/fcoemon_utils.h
@@ -40,7 +40,6 @@
 #include "fc_types.h"
 
 void sa_log(const char *format, ...);
-void sa_log_func(const char *func, const char *format, ...);
 void sa_log_err(int, const char *func, const char *format, ...);
 
 /*




More information about the devel mailing list