[Open-FCoE] [RFC PATCH 2/3] fcoe: Return ERESTARTSYS on rtnl_trylock failure

Bhanu Gollapudi bprakash at broadcom.com
Tue Jan 11 03:18:52 UTC 2011


fcoe driver should return -ERESTARTSYS instead of -ENODEV so
that rtnl lock will be retried.

Signed-off-by: Bhanu Prakash Gollapudi <bprakash at broadcom.com>
---
 drivers/scsi/fcoe/fcoe.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index d08efea..dcde6d3 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1910,7 +1910,7 @@ static int fcoe_disable(struct net_device *netdev)
 
 	if (!rtnl_trylock()) {
 		mutex_unlock(&fcoe_config_mutex);
-		return -ENODEV;
+		return -ERESTARTSYS;
 	}
 
 	fcoe = fcoe_hostlist_lookup_port(netdev);
@@ -1954,7 +1954,7 @@ static int fcoe_enable(struct net_device *netdev)
 #endif
 	if (!rtnl_trylock()) {
 		mutex_unlock(&fcoe_config_mutex);
-		return -ENODEV;
+		return -ERESTARTSYS;
 	}
 
 	fcoe = fcoe_hostlist_lookup_port(netdev);
@@ -1997,7 +1997,7 @@ static int fcoe_destroy(struct net_device *netdev)
 #endif
 	if (!rtnl_trylock()) {
 		mutex_unlock(&fcoe_config_mutex);
-		return -ENODEV;
+		return -ERESTARTSYS;
 	}
 
 	fcoe = fcoe_hostlist_lookup_port(netdev);
@@ -2050,7 +2050,7 @@ static int fcoe_create(struct net_device *netdev, enum fip_state fip_mode)
 
 	if (!rtnl_trylock()) {
 		mutex_unlock(&fcoe_config_mutex);
-		return -EIO;
+		return -ERESTARTSYS;
 	}
 
 #ifdef CONFIG_FCOE_MODULE
-- 
1.7.0.6







More information about the devel mailing list