[Open-FCoE] [PATCH v2] fcoe-utils: add DRIVER_NAME to specify the FCoE low-level driver

Bhanu Gollapudi bprakash at broadcom.com
Tue Jan 18 20:56:00 UTC 2011


On Tue, 2011-01-18 at 11:52 -0800, Robert Love wrote:
> On Mon, 2011-01-17 at 18:22 -0800, Bhanu Gollapudi wrote:
> > On Mon, 2011-01-17 at 17:35 -0800, Robert Love wrote:

> > > 
> > >    Also, I was trying to test Yi/Bhanu's v3 kernel series with this
> > > fcoe-utils patch and I can't get things to work.
> > > 
> > >    After running 'fipvlan -ac' interface 'eth3.170-fcoe' is created.
> > > When I try to create on that interface using 'fcoeadm -c eth3.170-fcoe'
> > > nothing happens except for the kernel reporting, "fcoe_transport_create:
> > > transport n/a failed to create fcoe on n/a"
> > 
> > Shouldn't we pass physical ethernet interface (eth4) instead of the vlan
> > interface?
> > 
> 
> Possibly. Passing the physical interface to the kernel would mean that
> we'd need to do VLAN discovery in the kernel. Since the general kernel
> attitude is to do as much as possible in user space and the fact that
> the current solution seems to work fine, nobody has tried to push VLAN
> discovery into the kernel.

Ok. when i said "pass physical eth interface instead of vlan interface",
I meant auto-vlan case.  In this case, when we send physical interface,
vlan discovery would happen, and fcoemon will have the vlan interface,
and it passes the same interface to the driver.

We missed the requirement about non-auto-vlan case.


> > 
> > > When I try 'fcoeadm -c eth3.170-fcoe:fcoe' I get the following system
> > > panic.
> > > 
> > >    With fcoe.ko how are you expecting the user to use 'fcoeadm -c', with
> > > the ':<driver>' or not? 
> > We expect user to use 'fcoeadm -c' without a :<driver>
> > 
> 
> How will the bnx2fc driver be selected if there is no config file? Also,
> with this patch if the user doesn't have the foresight to edit the
> DRIVER_NAME before starting fcoemon then they're stuck with the default.

We will work on the changes to fcoemon/fcoeadm to work in non-auto-vlan
case. IOW, support 'fcoeadm -c ethX.<vlan_id>-fcoe:<driver_name>'.

Thanks,
Bhanu






More information about the devel mailing list