[Open-FCoE] [PATCH v2] fcoe-utils: add DRIVER_NAME to specify the FCoE low-level driver

Bhanu Gollapudi bprakash at broadcom.com
Wed Jan 19 01:17:03 UTC 2011


On Tue, 2011-01-18 at 16:07 -0800, Zou, Yi wrote:

> > 
> > I like this because the user doesn't have to make any changes to the
> > config files for a new driver. All we need to do is have an in-kernel
> > match routine for bnx2fc (or any other fcoe driver). The "create" entry
> > point would only receive the ifname. libfcoe would then go through the
> > list of registered transports, calling match() on each to find which
> > driver should be used with the provided interface's netdev instance.
> > We'd need to put any fcoe drivers first in the match list and have the
> > default always be fcoe.ko.
> Yeah, that was what I originally proposed, DRIVER_NAME does seem to simplify
> things but as I said before, user can pass whatever driver to whatever
> interface, then you depend on the create() function to fail as an indication
> of mismatch.
> 
> > 
> > To accomplish this we would just need to update Yi's series with this
> > transport lookup/match code, we'd need to have a match() routine for
> > bnx2fc and we wouldn't need to make any changes to fcoe-utils.
> > 
> > The only thing that I don't like about this is that the fcoe service
> > will still need to load all fcoe drivers when it starts since they need
> > to be loaded to register as fcoe transports. I can't think of a way
> > around this at this point.
> This can be done by loading the corresponding driver module at run time,
> using the module alias macro I added there MODULE_ALIAS_FCOE_PCI. The
> problem is that I can't find a way to nicely format the alias like other
> drivers do since they have pci device table in the .mod.c file that is
> pulled by modpost and is properply formatted to be like,
> 
> pci:v0000xxxxdxxxxsv*sd*bc*sc*i*
> 
> but, that’s the idea.

Are we planning to remove "SUPPORTED_DRIVERS" in /etc/fcoe/config file
as well?  The above problem can easily be solved with SUPPORTED_DRIVERS.

If we do not want it in the config file, should the new transports
hardcode the driver name to be modprobed in the /etc/init.d/fcoe?

> 
> Thanks,
> yi
> 
> 
> > 
> > Thanks, //Rob
> > 
> > _______________________________________________
> > devel mailing list
> > devel at open-fcoe.org
> > https://lists.open-fcoe.org/mailman/listinfo/devel
> 






More information about the devel mailing list