[Open-FCoE] [RFC PATCH 1/4] libfcoe: move common functions/structures from fcoe

Zou, Yi yi.zou at intel.com
Mon Jan 24 17:47:03 UTC 2011


> On Thu, 2011-01-20 at 23:56 -0800, Zou, Yi wrote:
> 
> Thanks for your review comments, Yi.
> 
> 
> > > To facilitate LLDDs to reuse the code, skb queue related functions
> are
> > > moved to
> > > libfcoe, so that both fcoe and bnx2fc drivers can use them. The
> common
> > > structures
> > > fcoe_port, fcoe_percpu_s are moved to libfcoe. fcoe_port will now
> have an
> > > opaque pointer that points to corresponding driver's interface
> structure.
> >
> >
> > fcoe_ctrl.c is all FIP codes, it'd make more sense to have these codes
> in
> > a separate c file.
> 
> yes, you're right. how about using fcoe_transport.c?
> 
Sure, that works for me.

Thanks,
yi





More information about the devel mailing list