[Open-FCoE] [v4 PATCH 1/5] libfcoe: Move common code from fcoe.c to libfcoe.c

Bhanu Gollapudi bprakash at broadcom.com
Wed Jan 26 08:20:37 UTC 2011


On Tue, 2011-01-25 at 23:53 -0800, Zou, Yi wrote:
> > 
> > fcoe_start_io and fcoe_fc_crc are moved to libfcoe so that both
> > fcoe and bnx2fc drivers can use these common functions.
> > 
> > As part of this change, fixed fcoe_start_io to return ENOMEM if
> > skb_clone fails.
> > 
> > Signed-off-by: Bhanu Prakash Gollapudi <bprakash at broadcom.com>
> > ---
> >  drivers/scsi/fcoe/fcoe.c      |   58 -----------------------------------
> > --
> >  drivers/scsi/fcoe/fcoe_ctlr.c |   63
> > +++++++++++++++++++++++++++++++++++++++++
> >  include/scsi/libfcoe.h        |    2 +
> >  3 files changed, 65 insertions(+), 58 deletions(-)
> > 
> I thought you were moving to fcoe_transport.c? Also, the patch title
> needs fixing to reflect this as there is no libfcoe.c any more.

Yi, As you pointed out in seperate email, Robert has already committed
this patch to fcoe-next, which I didnt realize when submitting this.
I'll move these functions from fcoe_ctlr.c to fcoe_transport.c when I
submit the other patchset "[RFC PATCH 0/4] Move LLDD common code to
libfcoe" sometime tomorrow.

Thanks,
Bhanu
> 
> Thanks,
> yi
> 
> >
> > <-- snip -->
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 






More information about the devel mailing list