[Open-FCoE] [PATCH] libfc: Initialize list of EM anchors

Bhanu Gollapudi bprakash at broadcom.com
Wed Jan 26 22:38:29 UTC 2011


On Tue, 2011-01-11 at 15:25 -0800, Robert Love wrote:
> The list head was not being initialized.
> 
> Signed-off-by: Robert Love <robert.w.love at intel.com>
> Tested-by: Ross Brattain <ross.b.brattain at intel.com>
> ---
>  drivers/scsi/libfc/fc_lport.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c
> index e0ef814..c12f348 100644
> --- a/drivers/scsi/libfc/fc_lport.c
> +++ b/drivers/scsi/libfc/fc_lport.c
> @@ -1590,6 +1590,7 @@ void fc_lport_enter_flogi(struct fc_lport *lport)
>   */
>  int fc_lport_config(struct fc_lport *lport)
>  {
> +	INIT_LIST_HEAD(&lport->ema_list);

Robert, I think the ema_list is being initialized in libfc_host_alloc().
If we initialize here again, the NPIV ports will not get created, as
fc_exch_alloc() fails when trying to send FDISC.


>  	INIT_DELAYED_WORK(&lport->retry_work, fc_lport_timeout);
>  	mutex_init(&lport->lp_mutex);
>  
> 
> _______________________________________________
> devel mailing list
> devel at open-fcoe.org
> https://lists.open-fcoe.org/mailman/listinfo/devel
> 






More information about the devel mailing list