[Open-FCoE] [v4 PATCH 1/5] libfcoe: Move common code from fcoe.c to libfcoe.c

Bhanu Gollapudi bprakash at broadcom.com
Wed Jan 26 22:42:38 UTC 2011


On Wed, 2011-01-26 at 13:36 -0800, Robert Love wrote:
> On Wed, 2011-01-26 at 00:20 -0800, Bhanu Gollapudi wrote:
> > On Tue, 2011-01-25 at 23:53 -0800, Zou, Yi wrote:
> > > > 
> > > > fcoe_start_io and fcoe_fc_crc are moved to libfcoe so that both
> > > > fcoe and bnx2fc drivers can use these common functions.
> > > > 
> > > > As part of this change, fixed fcoe_start_io to return ENOMEM if
> > > > skb_clone fails.
> > > > 
> > > > Signed-off-by: Bhanu Prakash Gollapudi <bprakash at broadcom.com>
> > > > ---
> > > >  drivers/scsi/fcoe/fcoe.c      |   58 -----------------------------------
> > > > --
> > > >  drivers/scsi/fcoe/fcoe_ctlr.c |   63
> > > > +++++++++++++++++++++++++++++++++++++++++
> > > >  include/scsi/libfcoe.h        |    2 +
> > > >  3 files changed, 65 insertions(+), 58 deletions(-)
> > > > 
> > > I thought you were moving to fcoe_transport.c? Also, the patch title
> > > needs fixing to reflect this as there is no libfcoe.c any more.
> > 
> > Yi, As you pointed out in seperate email, Robert has already committed
> > this patch to fcoe-next, which I didnt realize when submitting this.
> > I'll move these functions from fcoe_ctlr.c to fcoe_transport.c when I
> > submit the other patchset "[RFC PATCH 0/4] Move LLDD common code to
> > libfcoe" sometime tomorrow.
> 
> Hi Bhanu,
> 
>    This was my fault. I thought the patch I committed was the right one.
> I'd rather push the correct patch to linux-scsi instead of this bad one
> and then a fix. I'll remove this patch from fcoe-next, can you post the
> finalized patch and I'll commit it?

OK. I'll send out the prep-work patches soon. After that I'll follow it
up with final bnx2fc patches (v5).

> 
>    Am I right that with all of the patches in fcoe-next (minus the mess
> up referenced above), that all the prep work and hooks are done for
> bnx2fc and you'll be able to drop your driver in? 

Yes.

> I really just want all
> the prep work to be integrated and go through fcoe-next and then you can
> post your final driver patches.

Sure. Will do.

Thanks,
Bhanu
> 
> Thanks, //Rob
> 
> 






More information about the devel mailing list